Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes demo file usage with latest syntax #33

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

Samuwhale
Copy link
Contributor

@Samuwhale Samuwhale commented May 29, 2024

The demo file and faker was loaded using outdated syntax, it's fixed now

Copy link
Member

@qubixes qubixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Apart from the idea configurations it's a nice catch!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might lead to merge conflicts with the other PR, hopefully not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess they are not necessary per se, but it was annoying to manually remove these files with every commit. But might be easier to switch to just ignoring .idea

@qubixes qubixes merged commit 90d8765 into sodascience:main Jun 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants